Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Dec 27, 2019

Description

Design pass review in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/456
This PR still use private SDK, since the swagger not merged.
send it early for start review early.
Will update to released SRP SDK , after swagger merged and SDK released

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

@blueww let us know when this is ready for review please

@blueww
Copy link
Member Author

blueww commented Dec 30, 2019

@isra-fel

As the swagger is not ready, we might can't catch 1/7 relase.
I will close this PR first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants