-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Cmdlets for CosmosDB Sql and Account Operations #10726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
tools/StaticAnalysis/Exceptions/Az.CosmosDB/AssemblyVersionConflict.csv
Outdated
Show resolved
Hide resolved
tools/StaticAnalysis/Exceptions/Az.CosmosDB/BreakingChangeIssues.csv
Outdated
Show resolved
Hide resolved
tools/StaticAnalysis/Exceptions/Az.CosmosDB/ExtraAssemblies.csv
Outdated
Show resolved
Hide resolved
tools/StaticAnalysis/Exceptions/Az.CosmosDB/MissingAssemblies.csv
Outdated
Show resolved
Hide resolved
tools/StaticAnalysis/Exceptions/Az.CosmosDB/SignatureIssues.csv
Outdated
Show resolved
Hide resolved
|
Please correct the mandatory property of the parameters. For NameParameterSet, name related parameters should be mandatory and for InputObjectParameterSet at least InputObject is mandatory. If correct all the cases. |
|
@msJinLei Please review at your earliest convenience. Addressed your previous comments. |
|
@MehaKaushik Please remove the modification of other modules. |
ecaf911 to
528d682
Compare
|
@msJinLei Made the changes as per your request, no other modules are being shown in the commit history now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If the cmdlet supports "shouldprocess", please call ShouldProcess in your method.
- For PassThru output, you can write bool to pipeline directly. No need to transform to string.
- Generally, it is a little strange to return error message as an output. You can WriteError and return false.
- PassThru is only required for Remove cmdlets, please return object modified in the New & Set & Update ones
- AsJob means the cmdlet costs a long time to run. Please double confirm all of your “AsJob"s are required.
- Please also involve one of your team members for logic integrity review.
src/CosmosDB/CosmosDB/CosmosDBAccount/RemoveAzCosmosDBAccount.cs
Outdated
Show resolved
Hide resolved
src/CosmosDB/CosmosDB/CosmosDBAccount/RemoveAzCosmosDBAccount.cs
Outdated
Show resolved
Hide resolved
src/CosmosDB/CosmosDB/CosmosDBAccount/UpdateAzCosmosDBAccountFailoverPriority.cs
Outdated
Show resolved
Hide resolved
|
@msJinLei Thanks for your review. I have addressed all of the comments. Please have another look. |
|
@msJinLei Please review at your earliest convenience. |
OK. I am working on fixing some urgent issues these days. And will review your PR when I have time. |
src/CosmosDB/CosmosDB/CosmosDBAccount/RemoveAzCosmosDBAccount.cs
Outdated
Show resolved
Hide resolved
src/CosmosDB/CosmosDB/SQL/RemoveAzCosmosDBSqlStoredProcedure.cs
Outdated
Show resolved
Hide resolved
src/CosmosDB/CosmosDB/SQL/RemoveAzCosmosDBSqlUserDefinedFunction.cs
Outdated
Show resolved
Hide resolved
src/CosmosDB/CosmosDB/CosmosDBAccount/NewAzCosmosDBAccountKey.cs
Outdated
Show resolved
Hide resolved
|
src/CosmosDB/CosmosDB/CosmosDBAccount/NewAzCosmosDBAccountKey.cs
Outdated
Show resolved
Hide resolved
src/CosmosDB/CosmosDB/CosmosDBAccount/UpdateAzCosmosDBAccount.cs
Outdated
Show resolved
Hide resolved
Cmdlets for CosmosDB Sql and Account Operations
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added