Update default context check option #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
reviewed
Mar 7, 2020
| /// If false, the logic of referencing default context would be omitted. | ||
| /// </summary> | ||
| protected virtual bool RequireDefaultContext => true; | ||
| protected virtual bool RequireDefaultContext() { return true; } |
Member
There was a problem hiding this comment.
We've already been using this property in two cmdlets. Changing it to a method will require us to change those cmdlets as well. Would you want me to do that?
Member
There was a problem hiding this comment.
For example here we need to do the following update
- protected override bool RequireDefaultContext => false;
+ protected override bool RequireDefaultContext() { return false; }
Member
Author
There was a problem hiding this comment.
yes. your original approach doesn't work. You can test too. No idea the syntax you are using. but my approach is the safe way and I verified it. I haven't submitted my commits in azure-powershell.
Member
Author
There was a problem hiding this comment.
I write a simple example. It shows your code is correct. I'd like to change them back to follow convention if there is no other problem.
isra-fel
pushed a commit
to Azure/azure-powershell
that referenced
this pull request
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.