Add Rpaas_ResourceProvisioningState, improve TopLevelResourcesListByResourceGroup #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2020 11:28
jianyexi
changed the title
added 2 commits
December 16, 2020 11:55
ruowan
reviewed
Dec 21, 2020
| const model = utils.getResourceByName(resource) | ||
| const properties = utils.getPropertyOfModel(model,"properties") | ||
| let hasProvisioningState = false | ||
| if (properties && (!properties.type || properties.type === "object")) { |
Contributor
Author
There was a problem hiding this comment.
yes, undefined type equals to "object"
ruowan
reviewed
Dec 21, 2020
ruowan
reviewed
Dec 21, 2020
| if (!model) { | ||
| return undefined | ||
| } | ||
| if (model.properties) { |
Contributor
Author
There was a problem hiding this comment.
No, 'propertyName' is variable
ruowan
reviewed
Dec 21, 2020
src/typescript/azure-openapi-validator/rules/utilities/resourceUtils.ts
Outdated
Show resolved
Hide resolved
ruowan
reviewed
Jan 4, 2021
src/typescript/azure-openapi-validator/rules/Rpaas_ResourceProvisioningState.ts
Show resolved
Hide resolved
ruowan
approved these changes
Jan 4, 2021
Contributor
Author
|
@sanjaiganesh could you help review the PR ? |
Contributor
Author
Run regression test against rpaasMaster branch , there are totally 17 Rpaas_ResourceProvisioningState rule errors |
ruowan
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc:
Azure/azure-rest-api-specs#12268