Gracefully handle lack of section.value["x-ms-enum"].name in UniqueXm…

…sEnumName. (#657)
Azure · Feb 1, 2024 · ddbf6b1 · ddbf6b1
1 parent ca41e85
commit ddbf6b1
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 45 deletions.
diff --git a/...-validator-core/akhilailla-add_rpc_guideline_code_to_linter_command_2024-01-30-20-53.json b/...-validator-core/akhilailla-add_rpc_guideline_code_to_linter_command_2024-01-30-20-53.json
diff --git a/...api-validator-rulesets/tejaswis-FPSPropertiesTypeObjectNoDefinition_2024-01-22-23-22.json b/...api-validator-rulesets/tejaswis-FPSPropertiesTypeObjectNoDefinition_2024-01-22-23-22.json
diff --git a/...penapi-validator-rulesets/tejaswis-fps-ParameterNotUsingCommonTypes_2024-01-24-18-56.json b/...penapi-validator-rulesets/tejaswis-fps-ParameterNotUsingCommonTypes_2024-01-24-18-56.json
diff --git a/...e_to_linter_command_2024-01-30-20-53.json → ...ator-rulesets/vbump_2024-02-01-23-09.json b/...e_to_linter_command_2024-01-30-20-53.json → ...ator-rulesets/vbump_2024-02-01-23-09.json
@@ -2,8 +2,8 @@
   "changes": [
     {
       "packageName": "@microsoft.azure/openapi-validator-rulesets",
-      "comment": "Upgrade version to 1.3.3",
-      "type": "patch"
+      "comment": "rush version --bump",
+      "type": "none"
     }
   ],
   "packageName": "@microsoft.azure/openapi-validator-rulesets"

diff --git a/...enapi-validator/akhilailla-add_rpc_guideline_code_to_linter_command_2024-01-30-20-53.json b/...enapi-validator/akhilailla-add_rpc_guideline_code_to_linter_command_2024-01-30-20-53.json
diff --git a/packages/rulesets/CHANGELOG.json b/packages/rulesets/CHANGELOG.json
@@ -1,6 +1,18 @@
 {
   "name": "@microsoft.azure/openapi-validator-rulesets",
   "entries": [
+    {
+      "version": "1.3.4",
+      "tag": "@microsoft.azure/openapi-validator-rulesets_v1.3.4",
+      "date": "Thu, 01 Feb 2024 23:08:29 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "Gracefully handle lack of section.value[\"x-ms-enum\"].name in UniqueXmsEnumName. Solves https://github.com/Azure/azure-openapi-validator/issues/654"
+          }
+        ]
+      }
+    },
     {
       "version": "1.3.3",
       "tag": "@microsoft.azure/openapi-validator-rulesets_v1.3.3",
@@ -24,6 +36,12 @@
           },
           {
             "comment": "Add RPC code to ProvisioningStateMustBeReadOnly and fix documentation"
+          },
+          {
+            "comment": "Fix a false alarm with the ParameterNotUsingCommonTypes rule that resulted in errors being flagged even when common-types were being referenced correctly."
+          },
+          {
+            "comment": "Fix an issue where PropertiesTypeObjectNoDefinition must verify the existence of the allOf property in the definition object."
           }
         ]
       }

diff --git a/packages/rulesets/CHANGELOG.md b/packages/rulesets/CHANGELOG.md
@@ -1,6 +1,13 @@
 # Change Log - @microsoft.azure/openapi-validator-rulesets
 
-This log was last generated on Tue, 30 Jan 2024 18:28:15 GMT and should not be manually modified.
+This log was last generated on Thu, 01 Feb 2024 23:08:29 GMT and should not be manually modified.
+
+## 1.3.4
+Thu, 01 Feb 2024 23:08:29 GMT
+
+### Patches
+
+- Gracefully handle lack of section.value["x-ms-enum"].name in UniqueXmsEnumName. Solves https://github.com/Azure/azure-openapi-validator/issues/654
 
 ## 1.3.3
 Tue, 30 Jan 2024 18:28:15 GMT
@@ -13,6 +20,8 @@ Tue, 30 Jan 2024 18:28:15 GMT
 - Update latestVersionOfCommonTypesMustBeUsed rule to check for latest version(V5) of all common types
 - Upgrade version to 1.3.2
 - Add RPC code to ProvisioningStateMustBeReadOnly and fix documentation
+- Fix a false alarm with the ParameterNotUsingCommonTypes rule that resulted in errors being flagged even when common-types were being referenced correctly.
+- Fix an issue where PropertiesTypeObjectNoDefinition must verify the existence of the allOf property in the definition object.
 
 ## 1.3.2
 Tue, 19 Dec 2023 21:25:29 GMT

diff --git a/packages/rulesets/package.json b/packages/rulesets/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@microsoft.azure/openapi-validator-rulesets",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "Azure OpenAPI Validator",
   "main": "dist/index.js",
   "scripts": {

diff --git a/packages/rulesets/src/native/legacyRules/UniqueXmsEnumName.ts b/packages/rulesets/src/native/legacyRules/UniqueXmsEnumName.ts
@@ -20,7 +20,7 @@ rules.push({
     if (node) {
       const enumMap = new Map<string, any>()
       for (const section of nodes(node, "$..*[?(@property === 'enum')]^")) {
-        if (section.value["x-ms-enum"] && isValidEnum(section.value)) {
+        if (isValidEnum(section.value) && section.value["x-ms-enum"] && section.value["x-ms-enum"].name) {
           const enumName = section.value["x-ms-enum"].name.toLowerCase()
           if (enumMap.has(enumName)) {
             const curEnum = section.value.enum