Add staging only

Azure · Sep 17, 2024 · d7fc645 · d7fc645
1 parent cd7f07f
commit d7fc645
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/packages/rulesets/generated/spectral/az-arm.js b/packages/rulesets/generated/spectral/az-arm.js
@@ -2692,10 +2692,7 @@ const queryParametersInCollectionGet = (pathItem, _opts, ctx) => {
     const GET = "get";
     const errors = [];
     for (const uri of uris) {
-        if (!pathItem[uri][GET]) {
-            continue;
-        }
-        if (isListOperation(uri)) {
+        if (pathItem[uri][GET] && isListOperation(uri)) {
             const params = pathItem[uri][GET]["parameters"];
             const queryParams = params === null || params === void 0 ? void 0 : params.filter((param) => param.in === "query" && param.name !== "api-version" && param.name !== "$filter");
             queryParams === null || queryParams === void 0 ? void 0 : queryParams.forEach((param) => {
@@ -3493,6 +3490,7 @@ const ruleset = {
             description: "Collection Get's/List operations MUST not have query parameters other than api-version & OData filter.",
             severity: "error",
             message: "{{error}}",
+            stagingOnly: true,
             resolved: true,
             formats: [oas2],
             given: "$[paths,'x-ms-paths']",

diff --git a/packages/rulesets/src/spectral/az-arm.ts b/packages/rulesets/src/spectral/az-arm.ts
@@ -456,6 +456,7 @@ const ruleset: any = {
       description: "Collection Get's/List operations MUST not have query parameters other than api-version & OData filter.",
       severity: "error",
       message: "{{error}}",
+      stagingOnly: true,
       resolved: true,
       formats: [oas2],
       given: "$[paths,'x-ms-paths']",

diff --git a/packages/rulesets/src/spectral/functions/query-parameters-in-collection-get.ts b/packages/rulesets/src/spectral/functions/query-parameters-in-collection-get.ts
@@ -14,12 +14,8 @@ export const queryParametersInCollectionGet = (pathItem: any, _opts: any, ctx: a
   const errors: any[] = []
 
   for (const uri of uris) {
-    // skip, if GET op isn't defined
-    if (!pathItem[uri][GET]) {
-      continue
-    }
-    // check if the GET op is a collection get/list call
-    if (isListOperation(uri)) {
+    //check if GET op is defined & the GET op is a collection get/list call
+    if (pathItem[uri][GET] && isListOperation(uri)) {
       const params = pathItem[uri][GET]["parameters"]
       const queryParams = params?.filter(
         (param: { in: string; name: string }) => param.in === "query" && param.name !== "api-version" && param.name !== "$filter",