Add UserId methods to NotificationHub class #86

varvusc · 2020-07-31T09:32:56Z

No description provided.

Swift Test App Refresh

Move all tests to WindowsAzureMessaging and fix them

Additional adjustment of tests and commands

# Conflicts: # src/WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/project.pbxproj

Add custom MSNotificationHubMessage

# Conflicts: # src/WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/project.pbxproj

Robust HttpClient from AppCenter repository with tests

Add Swizzling for AppDelegate lifecycle methods

* Update targets for Framework * Fixing BVT (add required frameworks for new SDK)

Create custom delegate for intercepting remote notifications

itoys

Add comparison here

azure-notificationhubs-ios/WindowsAzureMessaging/WindowsAzureMessaging/Model/MSInstallation.m

Lines 228 to 234 in b5ee264

    
           - (BOOL)isEqualToMSInstallation:(MSInstallation *)installation { 
        
               BOOL isInstallationsIdEqual = [self.installationId isEqualToString:installation.installationId]; 
        
               BOOL isExpirationTimeEqual = ((!self.expirationTime && !installation.expirationTime) || [[NSCalendar currentCalendar] isDate:self.expirationTime equalToDate:installation.expirationTime toUnitGranularity:NSCalendarUnitDay]); 
        
               BOOL isTagsSetEqual = ((!self.tags && !installation.tags) || [self.tags isEqualToSet:installation.tags]); 
        
               BOOL isTemplatesDictionaryEqual = ((!self.templates && !installation.templates) || [self.templates isEqualToDictionary:installation.templates]); 
        
               return isInstallationsIdEqual && isExpirationTimeEqual && isTagsSetEqual && isTemplatesDictionaryEqual; 
        
           }

* Adding templates for issues/PR * Updating with versions

* SwiftUI Notification Hubs Sample App for iOS * SwiftUI Notification Hubs Sample App for MacOS * update workspace Co-authored-by: Matthew Podwysocki <[email protected]>

mpodwysocki · 2020-08-12T14:48:37Z

@varvusc can you rebase and merge the changes from master?

itoys · 2020-08-12T14:54:46Z

@varvusc can you rebase and merge the changes from master?

I'll do

itoys · 2020-08-12T16:52:49Z

@varvusc can you rebase and merge the changes from master?

Done!

mpodwysocki

LGTM

mpodwysocki and others added 30 commits April 21, 2020 17:24

Initial commit

7f909ec

Updating MSNotification.m

b2ab515

Deleting bad files

20dd996

Update commands

6cf29ae

Test app refresh swift (#42)

83c896e

Swift Test App Refresh

Move tests to common folder

9c8229a

Update links at test project

9d53bc9

Fix tests

2c5772c

Add Sample App using NH iOS SDK V3 (#44)

7ce1f11

Merge pull request #45 from Azure/moving-tests

1fdd118

Move all tests to WindowsAzureMessaging and fix them

Add HttpClient and all dependencies from AppCenter

29340bf

Add tests for http client

c58dee5

Update test schema

489bea6

Back schema to static from library for tests

e1fd9e9

Remove separate project for tests

1d85260

Update commands for CIT and BVT

0b50af0

Add frameworks for testings

faa0036

Intermediate state for fixing tests for http client

f35116c

Fix reference for OHHTTPStubs

47df374

Fix tests for http client

90b657c

Merge pull request #48 from Azure/move-tests

615aa1e

Additional adjustment of tests and commands

Merge remote-tracking branch 'origin/sdk-v3' into httpclient

a7681c3

# Conflicts: # src/WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/project.pbxproj

Rename AppCenter components to NotificationHub

ecb6f16

Add custom MSNotificationHubMessage (#51)

34ba872

Add custom MSNotificationHubMessage

Merge branch 'sdk-v3' into httpclient

cee4ca8

# Conflicts: # src/WindowsAzureMessaging/WindowsAzureMessaging.xcodeproj/project.pbxproj

Merge pull request #50 from Azure/httpclient

18bc99b

Robust HttpClient from AppCenter repository with tests

Add Swizzling for AppDelegate lifecycle methods (#49)

b29c69b

Add Swizzling for AppDelegate lifecycle methods

Fixing BVT tests (#53)

7b542c8

* Update targets for Framework * Fixing BVT (add required frameworks for new SDK)

Create custom delegate for intercepting remote notifications (#52)

51c1bb0

Create custom delegate for intercepting remote notifications

Update sample app for Objective-C for receiving pushes

494d481

varvusc marked this pull request as ready for review August 3, 2020 14:10

itoys requested a review from mpodwysocki August 3, 2020 14:34

itoys suggested changes Aug 3, 2020

View reviewed changes

add UserId to isEqual method

292f5dd

itoys self-requested a review August 3, 2020 15:19

add and fix unit tests

5edcaea

itoys approved these changes Aug 3, 2020

View reviewed changes

mpodwysocki and others added 11 commits August 3, 2020 14:21

Updating sample apps

b12cd61

Adding templates for issues/PR (#90)

5cadbb8

* Adding templates for issues/PR * Updating with versions

SwiftUI Notification Hubs Sample Apps for iOS and MacOS (#89)

3ecbb08

* SwiftUI Notification Hubs Sample App for iOS * SwiftUI Notification Hubs Sample App for MacOS * update workspace Co-authored-by: Matthew Podwysocki <[email protected]>

Adding icons/splashscreen to SwiftUI

a0cfe38

Updating README with new samples

c4ed487

Merge branch 'sdk-v3' into add-userid-methods-to-notificationhub-class

2fd4dc4

Merge branch 'sdk-v3' into add-userid-methods-to-notificationhub-class

3a9d063

update swiftui samples to use user id

8b64d03

update storyboard samples to use user id

f00200b

update mac storyboard samples to use user id

fa9ff0c

rerun pipeline

4995b35

itoys changed the base branch from sdk-v3 to master August 11, 2020 17:29

itoys changed the base branch from master to sdk-v3 August 12, 2020 08:46

itoys changed the base branch from sdk-v3 to master August 12, 2020 08:56

itoys added 2 commits August 12, 2020 19:49

Merge branch 'master' into add-userid-methods-to-notificationhub-class

573da1c

revert endline

f7e5ffb

fix tests

d191f15

mpodwysocki approved these changes Aug 17, 2020

View reviewed changes

mpodwysocki merged commit 8ee6570 into master Aug 17, 2020

mpodwysocki deleted the add-userid-methods-to-notificationhub-class branch August 17, 2020 21:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add UserId methods to NotificationHub class #86

Add UserId methods to NotificationHub class #86

varvusc commented Jul 31, 2020

itoys left a comment •

edited

Loading

mpodwysocki commented Aug 12, 2020

itoys commented Aug 12, 2020

itoys commented Aug 12, 2020

mpodwysocki left a comment

	- (BOOL)isEqualToMSInstallation:(MSInstallation *)installation {
	BOOL isInstallationsIdEqual = [self.installationId isEqualToString:installation.installationId];
	BOOL isExpirationTimeEqual = ((!self.expirationTime && !installation.expirationTime) \|\| [[NSCalendar currentCalendar] isDate:self.expirationTime equalToDate:installation.expirationTime toUnitGranularity:NSCalendarUnitDay]);
	BOOL isTagsSetEqual = ((!self.tags && !installation.tags) \|\| [self.tags isEqualToSet:installation.tags]);
	BOOL isTemplatesDictionaryEqual = ((!self.templates && !installation.templates) \|\| [self.templates isEqualToDictionary:installation.templates]);
	return isInstallationsIdEqual && isExpirationTimeEqual && isTagsSetEqual && isTemplatesDictionaryEqual;
	}

Add UserId methods to NotificationHub class #86

Add UserId methods to NotificationHub class #86

Conversation

varvusc commented Jul 31, 2020

itoys left a comment • edited Loading

Choose a reason for hiding this comment

mpodwysocki commented Aug 12, 2020

itoys commented Aug 12, 2020

itoys commented Aug 12, 2020

mpodwysocki left a comment

Choose a reason for hiding this comment

itoys left a comment •

edited

Loading