Refactoring GuestAgent based Logging Mechanism #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arisettisanjana
requested review from
iamashwani-who,
vityagi and
mearvind
as code owners
arisettisanjana
changed the title
arisettisanjana
commented
Sep 24, 2024
| os.makedirs(self.temporary_directory) | ||
| FileHelpers.clearOldJsonFilesInDirectory(self.temporary_directory) | ||
|
|
||
|
|
There was a problem hiding this comment.
will remove the extra line
| @@ -173,18 +168,19 @@ def _process_events(self): | |||
| return | |||
| if not self.event_queue.empty(): | |||
| if sys.version_info[0] == 2: | |||
| event_file_path = os.path.join(self.temporary_directory, "{}.json".format(int(time.time() * 1000000000))) | |||
| event_file_path = os.path.join(self.events_folder, "{}.json".format(int(time.time() * 1000000000))) | |||
There was a problem hiding this comment.
can you please make this change behind a flag to switch to older implementation since new implementation requires testing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to capture logs for each extension run, we use the event logging feature provided by the Guest Agent, which pushes extension telemetry to the AzCore Kusto cluster's fa database. This process involves initially writing logs to a temporary directory under the events folder. However, this occasionally leads to a non-blocking error, "failed to clear the temp directory," which occurs when the Guest Agent checks the events folder before the temporary directory has been cleaned up.
Solution:
To address this now we are directly writing files to the events folder.