Conversation
|
@milismsft @anuchandy Moved to a new PR here, thank you! |
|
@tiffanyachen LGTM but you still need to pass Travis CI. There are build failures in your PR such as: |
|
@tiffanyachen PR i still failing with what it looks like JavaDoc related errors. Try to reproduce them locally by running: |
|
@anuchandy @milismsft Could you take another look? Looks like the failure is on app-service |
|
@tiffanyachen can you try to run the test locally and confirm that this is not just a random failure? To do that in a different terminal first run "mvn jetty:run" and once you see the "Starting..." message go to the other terminal and execute "mvn test" from the root of the repo. |
|
|
|
@milismsft I don't think this is a random failure - KV is doing fine |
|
@tiffanyachen it is possible that other tests outside KeyVault directory might be making calls to create and set key vaults (I have couple in the SQL sample too) so for those tests you also need to re-record them. |
|
@milismsft IIRC I think Anu said he'd do the App service stuff, last Friday @anuchandy Are we at a similar state wrt where we left off last Friday? I'm not as familiar with the other tests in app service. |
|
Hey @tiffanyachen , I meet the same problem last Saturday in my PR azure-libraries-for-java#455. I mean the App Service Management test failure. Today I modify my commit message to trigger another build, and it succeeds. Hope it also works for you. |
* Generate key vault 2018-02-14-preview * kv2018 Sync with upstream master (#446) * Added namespace filtering for Monitor Metrics query. (#427) * Added namespace filtering for Monitor Metrics query. * re-recorded test * Regenerated Batch from swagger tag=package-2017-09 (#429) * Regenerated Batch from swagger tag=package-2017-09 * Re-recorded tests. * Re-recorded Batch sample. * Fix JavaDoc NPE exception when generating JavaDoc under JDK 9 (#410) * Fix use of ampersand characters in JavaDoc by replacing with & * Update JavaDoc comment that incorrectly attempts to use @link to reference a type U, where U is not a class that can be looked up. This results in a JavaDoc NPE when using JDK 9, preventing JavaDoc from being generated for this library due to the issue discussed at https://bugs.openjdk.java.net/browse/JDK-8188248 * Updating Network (#428) * Added application security groups * Added route filters * Added route filter rules * checkstyle * Adding list availbale providers for network watcher * Adding reachability report for network watcher * checkstyle * Connection Monitor for Network Watcher * test for Connection Monitor * Adding DDoS protection plans * Adding disableBgpRoutePropagation property to RouteTable * checkstyle * Adding DDoS protection plans and VM protection * remoteAddressSpace property for NetworkPeering * updateTags() for LocalNetworkGateway * updateTags() for Network * updateTags() for ExpressRouteCircuit, NetworkSecurityGroup, PublicIPAddress, NetworkWatcher, VirtualNetworkGateway * updateTags() for NetworkInterface * updateTags() for RouteTable * checkstyle * updateTags() for LoadBalancer, ApplicationGateway and VirtualNetworkGatewayConnection Protocol setter for connectivity check * ipTags for PublicIPAddress * adding application security groups for NetworkInterface * fixing build * session record * addressing code review * Add implementation to create Cassandra, Azure Table and Gremlin data model CosmosDB accounts. (#431) * Batch AI bugfix (#434) * Batch AI bugfix * Batch AI bugfix * Batch AI usages operation * Addressing code review * Adding new Australia Central regions (#436) * Re-record multiple wars test (#440) * Readme 1.10 (#439) * Readme 1.10 (#437) first draft * adding changes for Batch AI * updating migration notes * Up versions * [maven-release-plugin] prepare release v1.10.0 * [maven-release-plugin] prepare for next development iteration * AKS: Kubernetes versions support (#442) * Add new Kubernetes versions and implement overload to pass the version as a string value. * ACI: refactoring and add support for launchExec() operation. (#444) * Refactoring and add support for launchExec() operation. * Added storage method annotation to Fluent flow (#443) * Added storage method annotation to Fluent flow * Added more Method annotation to Storage * Added enableSoftDelete, DeletedVault, and Purge to method group (#432) * Added enableSoftDelete, DeletedVault, and Purge to method group * re-recorded tests * Updates from code review * Updated access policy to include storage * Moved converter for DeletedVaultInner * Added async methods * Removed unecessary async methods and SupportsListing<Vault> from Vaults, updates to checkNameAvailabilityResult * Simplified async access and elevated properties for Vault and DeletedVault * Updated checkstyle * Elevated access policies * Moved recovery of softDeletedVault to independent method * Changed purgeDeletedAsync to return Completable * Removed unused interfaces and added beta annotations * Unused imports in vaultImpl * Updated javadocs for accessPolicy * Kv2018 acl update (#449) * Added networkAcl access create/update * Updated network acls by elevating inner props * Vault had extraneous method * Fixed javadoc errors for keyvault * Corrected and rerecorded tests * Moving the wrap deployment portion of app-service test to run only on live
* Added build tools * Revert of uri change for linux test
4 participants
Moving this to new branch - updated with network ACL policies.