Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where module client send batch fails if output name already set #3441

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

timtay-microsoft
Copy link
Member

#3434

The method Add on a dictionary throws if the key is already present. This change will overwrite any previously set output name without throwing.

@timtay-microsoft
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add in a test to validate this behavior.

@timtay-microsoft
Copy link
Member Author

Test added

@timtay-microsoft
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@timtay-microsoft timtay-microsoft merged commit df0634b into main Mar 13, 2024
9 checks passed
@timtay-microsoft timtay-microsoft deleted the timtay/fix branch March 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants