-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gateway hostname from options for connection string flow #3326
Conversation
Should the connection string values override client options or the other way around? |
This is the way I see it - the connection string is the most client specific argument, i.e. it is credential specific to this client instance. So, whatever value I specify in there, that should take precedence. What do you think? |
Co-authored-by: David R. Williamson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I did merge this PR in already, but I synced up with David now and we're going to take it up as a parking lot item as a team for our next scrum. |
The GatewayHostName set in IotHubClientOptions was being ignored for the connection string flow.
This PR updates our SDK to consider this value even when connection strings are used. If a gateway hostname is already specified in the connection string directly, then the value set through options is ignored.