Remove methods from PayloadConvention that are only needed by the DefaultPayloadConvention class #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
drwill-ms
commented
Apr 18, 2023
drwill-ms
commented
Apr 18, 2023
drwill-ms
commented
Apr 18, 2023
abhipsaMisra
approved these changes
Apr 18, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…aultPayloadConvention
drwill-ms
force-pushed
the
drwill/payload-convention
branch
from
dad6180
to
bc5fa27
Compare
drwill-ms
force-pushed
the
drwill/payload-convention
branch
from
320e567
to
56b29fe
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can simplify the PayloadConvention base class by removing 2 methods that are really only required on the DefaultPayloadConvention class.