Miscellaneous DPS service client cleanup #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timtay-microsoft
commented
Apr 13, 2023
timtay-microsoft
commented
- Move JsonSerializerSettingsInitializer and PageableHelpers to the Utilities folder
- Rename ResponseBody to ErrorResponse
- Remove unused fields in QueryBuilder
- Move JsonSerializerSettingsInitializer and PageableHelpers to the Utilities folder - Rename ResponseBody to ErrorResponse - Remove unused fields in QueryBuilder
timtay-microsoft
requested review from
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Comment on lines
10
to
11
| [JsonProperty("errorCode")] | ||
| internal int ErrorCode { get; set; } |
There was a problem hiding this comment.
Oh, so this property is not for general "status code" (2XX) as well, right?
There was a problem hiding this comment.
Hmm, it's interesting that we have another property called "Code" and getting from this property.
There was a problem hiding this comment.
This class is only used to deserialize the HTTP response in cases where the HTTP status is not 200 or 204, but I suspect this field is still the same value as the HTTP status code
brycewang-microsoft
approved these changes
Apr 13, 2023
patilsnr
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.