Fix some ErrorCode in IotHubServiceException #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycewang-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
tmahmood-microsoft and
patilsnr
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tmahmood-microsoft
approved these changes
Apr 6, 2023
patilsnr
approved these changes
Apr 6, 2023
drwill-ms
reviewed
Apr 6, 2023
drwill-ms
approved these changes
Apr 6, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of mapping
HttpRequestExceptionintoIotHubServiceException, we manually put "RequestTimeout" asStatusCodeand "Unknown" asErrorCodeas there's nothing actually returned from the service. Now we add a new ErrorCode "GenericRequestTimeout" and use that instead.Also addressing a few more fixes in this PR.