-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TelemetryMessage should be able to take bytes and not serialize them #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
April 4, 2023 22:46
drwill-ms
commented
Apr 4, 2023
drwill-ms
commented
Apr 4, 2023
drwill-ms
commented
Apr 4, 2023
drwill-ms
commented
Apr 4, 2023
patilsnr
approved these changes
Apr 4, 2023
* Rename and cleanup ErrorDelegatingHandler * Fix test failure and rename tests * fatal exception types doesn't need to be a hashset * Fix test * Fix AMQP exception for scenario * Remove unecessary statements from test * Fix fault injection tests broken with gateway v2 * In person CR with Abhipsa * Fix fault injection error handling over MQTT
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.