Utilize AsyncPageable for DPS query return types #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change requires we copy some internal code from the Azure.Core library, but the public facing classes are the Azure.Core defined classes.
Co-authored-by: David R. Williamson <[email protected]>
This reverts commit ce9e37f.
…csharp into timtay/AsyncPageable
|
/azp run |
timtay-microsoft
requested review from
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
patilsnr
approved these changes
Mar 21, 2023
...sioning/service/samples/getting started/CleanupEnrollmentsSample/CleanupEnrollmentsSample.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 21, 2023
drwill-ms
reviewed
Mar 21, 2023
drwill-ms
reviewed
Mar 21, 2023
| cancellationToken) | ||
| .ConfigureAwait(false); | ||
|
|
||
| Stream responseStream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
No because it is given to the user to view as part of the Response<T> pattern that AsyncEnumerable uses. It is the user's responsibility to dispose the stream here.
There was a problem hiding this comment.
Because it is part of QueryResponse, which is also IDisposable?
There was a problem hiding this comment.
Is there an E2E test or a sample that shows how to dispose it?
drwill-ms
approved these changes
Mar 21, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Add samples in xml docs for disposing when iterating by page, make sure we are following that pattern in our samples/e2e tests |
|
Have the sample xml docs not print out the raw individual enrollment type class. Print out something interesting instead |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3165, but for the DPS service client this time.
This PR also removes some superfluous classes like
ContractApiResponsesince they were needless abstractions that made it harder to implement this changeI also change all the
CreateAsyncQuery APIs to justCreatesince the function itself is not async. The first service request isn't made until the iteration begins.I also removed the
IContractApiHttpinterface since it only had one implementation and we don't currently allow users to override this implementation in any way.