BugFix(MQTT): send an event in ReceiveMessageHandler before completin… #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g received message
tmahmood-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
ngastelum-ms,
patilsnr and
schoims
as code owners
patilsnr
approved these changes
Feb 15, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
approved these changes
Feb 16, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Feb 21, 2023
| // Messages with QoS = 1 need to be Acknowledged otherwise it results in mismatched Ack to IoT Hub | ||
| // causing next message being replayed and all subsequent messages being queued. | ||
| await CompleteIncomingMessageAsync(message).ConfigureAwait(false); | ||
| await TaskHelpers.CompletedTask.ConfigureAwait(false); |
There was a problem hiding this comment.
Why await this instead of removing the async keyword from the method?
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
…g received message (Azure#3116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MQTT, after receiving C2D message, the implementation was making an additional call to CompleteAsync(). This did not cause an issue if message handler was eventually only making call to Complete/Abandon/RejectAsync() but if an event was sent within message handler, the ACKs within CompleteAsync() get mismatched. The mismatch was due to awaited event call causing delay in ACK for the first lock token. i.e:
Flow with no event within message handler:
Flow with event within message handler: