Skip to content

Add error handling for hub connection-string show#320

Merged
digimaun merged 5 commits into
Azure:devfrom
vilit1:conn-str-show
Mar 16, 2021
Merged

Add error handling for hub connection-string show#320
digimaun merged 5 commits into
Azure:devfrom
vilit1:conn-str-show

Conversation

@vilit1
Copy link
Copy Markdown
Contributor

@vilit1 vilit1 commented Mar 12, 2021


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have you made an entry in HISTORY.rst which concisely explains your feature or change?

@vilit1 vilit1 requested a review from digimaun as a code owner March 12, 2021 22:17
@vilit1
Copy link
Copy Markdown
Contributor Author

vilit1 commented Mar 12, 2021

image

Comment thread azext_iot/operations/hub.py Outdated
Comment thread azext_iot/tests/iothub/test_iot_ext_int.py Outdated
Comment thread azext_iot/tests/iothub/test_iot_ext_int.py Outdated
Comment thread azext_iot/operations/hub.py
Comment thread azext_iot/_params.py
@vilit1
Copy link
Copy Markdown
Contributor Author

vilit1 commented Mar 16, 2021

image

Comment thread azext_iot/_help.py
@@ -107,24 +107,24 @@
"iot hub connection-string show"
] = """
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These improvements look great

@digimaun digimaun merged commit d830e62 into Azure:dev Mar 16, 2021
@vilit1 vilit1 deleted the conn-str-show branch April 19, 2021 18:32
c-ryan-k pushed a commit to c-ryan-k/azure-iot-cli-extension that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants