Skip to content

Add Etags to dps and dt, unit tests#307

Merged
digimaun merged 33 commits into
Azure:devfrom
vilit1:etags_unit_tests
Feb 5, 2021
Merged

Add Etags to dps and dt, unit tests#307
digimaun merged 33 commits into
Azure:devfrom
vilit1:etags_unit_tests

Conversation

@vilit1
Copy link
Copy Markdown
Contributor

@vilit1 vilit1 commented Jan 29, 2021


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have you made an entry in HISTORY.rst which concisely explains your feature or change?

@vilit1 vilit1 requested a review from digimaun as a code owner January 29, 2021 23:26
@vilit1
Copy link
Copy Markdown
Contributor Author

vilit1 commented Feb 4, 2021

image

digimaun
digimaun previously approved these changes Feb 5, 2021
@digimaun
Copy link
Copy Markdown
Member

digimaun commented Feb 5, 2021

Thanks for the great contribution. The only thing I would like to see is adding to the DPS unit tests on the etag sensitive functionality so we can make sure it's properly evaluating to "*" if no etag otherwise the etag value.

@vilit1
Copy link
Copy Markdown
Contributor Author

vilit1 commented Feb 5, 2021

image

@digimaun digimaun merged commit 660f8d5 into Azure:dev Feb 5, 2021
@vilit1 vilit1 deleted the etags_unit_tests branch February 24, 2021 19:49
c-ryan-k pushed a commit to c-ryan-k/azure-iot-cli-extension that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants