Skip to content

Release pipeline and Integration test refactor#291

Merged
digimaun merged 7 commits into
Azure:devfrom
c-ryan-k:test_refactor
Jan 5, 2021
Merged

Release pipeline and Integration test refactor#291
digimaun merged 7 commits into
Azure:devfrom
c-ryan-k:test_refactor

Conversation

@c-ryan-k
Copy link
Copy Markdown
Member

@c-ryan-k c-ryan-k commented Dec 15, 2020

Moved integration tests into more structured folders and updated imports

Updated release pipeline to run individually grouped RP tests in concurrent tasks (which allows for re-runs of failed test files for specific RPs)


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have you made an entry in HISTORY.rst which concisely explains your feature or change?

Moved integration tests into more structured folders and updated imports

Updated release pipeline to run individually grouped RP tests in concurrent tasks
@c-ryan-k
Copy link
Copy Markdown
Member Author

Leaving this open as a draft currently - would like to get our next release out before we overhaul the release pipeline :)

)
# Wait for RBAC to catch-up
sleep(20)
sleep(60)
Copy link
Copy Markdown
Member Author

@c-ryan-k c-ryan-k Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't seem to help the test_dt_twin_lifecycle_int tests, but I'm not sure if that's because it actually needs more time, or if the timing of RBAC isn't the issue here. The failing command executes successfully locally after the test fails, so my assumption was that the timing just needs to be tuned a bit more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep an eye on this, one potential cause I am thinking is a token caching issue. Looking into it a bit, interestingly enough, role-assignment propagation delays can take up to 30 minutes and for faster turn-around you can force a refresh by logging out and in again - official guidance.

@c-ryan-k c-ryan-k marked this pull request as ready for review December 17, 2020 21:12
@c-ryan-k c-ryan-k requested a review from digimaun as a code owner December 17, 2020 21:12
@c-ryan-k c-ryan-k requested a review from a user December 17, 2020 21:12
@digimaun digimaun self-assigned this Dec 18, 2020
@digimaun
Copy link
Copy Markdown
Member

Overall great improvements and refactoring's.

Moved dev test environment setup into template

Moved extension install and version detection into template

Modified parameters / var / and adjusted pipelines to use new values and templates
)

sleep(20) # Wait for service to catch-up
sleep(60) # Wait for service to catch-up
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another RBAC timer increase that did seem to help tests pass.

@digimaun digimaun merged commit 02c3551 into Azure:dev Jan 5, 2021
montgomp pushed a commit to montgomp/azure-iot-cli-extension that referenced this pull request Jan 5, 2021
* Release pipeline and Integration test refactor
* Moved integration tests into more structured folders and updated imports
* Updated release pipeline to run individually grouped RP tests in concurrent tasks
* Added correct unit test params to merge.yml
* Path updates for credscan suppression
* Moved dev test environment setup into template
* Moved extension install and version detection into template
* Modified parameters / var / and adjusted pipelines to use new values and templates
@c-ryan-k c-ryan-k deleted the test_refactor branch August 27, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants