Skip to content

Add dtdlv2 support#289

Merged
digimaun merged 25 commits into
devfrom
unknown repository
Dec 16, 2020
Merged

Add dtdlv2 support#289
digimaun merged 25 commits into
devfrom
unknown repository

Conversation

@valluriraj
Copy link
Copy Markdown
Contributor


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have you made an entry in HISTORY.rst which concisely explains your feature or change?

@valluriraj valluriraj requested a review from digimaun as a code owner December 11, 2020 09:45
@valluriraj valluriraj requested a review from a user December 11, 2020 09:45
Comment thread azext_iot/central/models/template.py Outdated
Comment thread azext_iot/monitor/property.py Outdated
Comment thread azext_iot/tests/central/json/device_template_int_test.json Outdated
Comment thread azext_iot/tests/central/json/device_template.json
Comment thread azext_iot/central/_help.py
Comment thread azext_iot/central/models/template.py Outdated
Comment thread azext_iot/monitor/property.py Outdated
Comment thread azext_iot/tests/central/json/property_validation_template.json
Comment thread azext_iot/tests/test_iot_central_unit.py
Comment thread HISTORY.rst
Comment thread azext_iot/central/models/template.py
Comment thread azext_iot/constants.py Outdated
Comment thread azext_iot/central/models/template.py
@valluriraj
Copy link
Copy Markdown
Contributor Author

image
central only tests

Comment thread azext_iot/central/models/template.py
Comment thread azext_iot/central/models/template.py
Comment thread azext_iot/monitor/parsers/central_parser.py Outdated
Comment thread azext_iot/monitor/parsers/central_parser.py
ghost
ghost previously approved these changes Dec 15, 2020
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for putting this hard work in. Good to get the validator back up and running

@valluriraj valluriraj requested a review from a user December 16, 2020 00:02
@digimaun digimaun merged commit 88ebac6 into Azure:dev Dec 16, 2020
montgomp pushed a commit to montgomp/azure-iot-cli-extension that referenced this pull request Jan 5, 2021
* Update parsing template logic to support  DTDLV2 models.
* Remove deprecated commands  1) iot central app device-twin 2) iot central app monitor-events
* Resolve PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants