Relax tightness of coupling in monitor code#174
Conversation
Author
|
|
ghost
marked this pull request as ready for review
ghost
changed the title
digimaun
reviewed
May 1, 2020
| import mock | ||
|
|
||
|
|
||
| class TestUamqpImport(object): |
digimaun
reviewed
May 1, 2020
| from abc import ABC, abstractmethod | ||
|
|
||
|
|
||
| class AbstractBaseEventsHandler(ABC): |
Member
There was a problem hiding this comment.
Good use of abstract base class.
Author
|
|
digimaun
reviewed
May 4, 2020
| properties, | ||
| content_type, | ||
| simulate_errors, | ||
| central_device_provider, |
Member
There was a problem hiding this comment.
Ultimately the provider for device templates needs to be abstracted and not assume Central (there are services other than Central that deal with device templates).
Author
There was a problem hiding this comment.
Agreed, I think that'll be the next item I'll address
digimaun
reviewed
May 4, 2020
| properties=None, | ||
| output=None, | ||
| validate_messages=None, | ||
| simulate_errors=None, |
Member
There was a problem hiding this comment.
The named args list here is getting too long - we should move the less commonly used to kwargs.
Author
There was a problem hiding this comment.
Agreed, I'll be addressing this as part of the next work item where I think I'll split the central parsing logic out so we dont have the _static_validation or _dynamic_validation calls in the common parser
digimaun
approved these changes
May 4, 2020
c-ryan-k
added a commit
to c-ryan-k/azure-iot-cli-extension
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
pytest <project root> -vv