Skip to content

Add leasesTableName to SqlTrigger Java annotation #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucyzhang929 merged 3 commits into from
Aug 2, 2023
Merged

Add leasesTableName to SqlTrigger Java annotation #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4dbe31
add leasestablename to java sqltrigger
lucyzhang929 Aug 1, 2023
7fbf7e5
add default value for commandtype
lucyzhang929 Aug 1, 2023
ec33e9a
remove sample
lucyzhang929 Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-library/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.microsoft.azure.functions</groupId>
<artifactId>azure-functions-java-library-sql</artifactId>
<version>2.0.0-preview</version> <!-- Update the dependency version in samples-java/pom.xml and test-java/pom.xml if this version is updated. -->
<version>2.1.0-preview</version> <!-- Update the dependency version in samples-java/pom.xml and test-java/pom.xml if this version is updated. -->
<packaging>jar</packaging>

<parent>
Expand Down
2 changes: 1 addition & 1 deletion java-library/src/main/java/com/microsoft/azure/functions/sql/annotation/SQLInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
/**
* Text or Stored Procedure.
*/
CommandType commandType();
CommandType commandType() default CommandType.Text;
Copy link
Contributor Author

@lucyzhang929 lucyzhang929 Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Text as default to be consistent with other languages.


/**
* Parameters to the query or stored procedure. This string must follow the format
Expand Down
7 changes: 7 additions & 0 deletions java-library/src/main/java/com/microsoft/azure/functions/sql/annotation/SQLTrigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,11 @@
* Setting name for SQL connection string.
*/
String connectionStringSetting();

/**
* Optional. Name of the table used to store leases. If not specified, the leases table name will be
* Leases_{FunctionId}_{TableId}. More information on how this is generated can be found here:
* https://github.com/Azure/azure-functions-sql-extension/blob/release/trigger/docs/TriggerBinding.md#az_funcleases_).
*/
String leasesTableName() default "";
}