Skip to content

Fix code coverage in trigger branch #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucyzhang929 merged 13 commits into from
Jul 10, 2023
Merged

Fix code coverage in trigger branch #880

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5629e5c
run only csharp test task
lucyzhang929 Jun 30, 2023
98834dc
comment out trigger tests
lucyzhang929 Jun 30, 2023
3cebee9
don't start func hosts in the beginning
lucyzhang929 Jul 3, 2023
bdc42a3
start three functions in beginning
lucyzhang929 Jul 3, 2023
a375eff
start only csharp host
lucyzhang929 Jul 6, 2023
a7486e6
fix build error
lucyzhang929 Jul 6, 2023
7d2b8d4
start both csharp and java hosts
lucyzhang929 Jul 6, 2023
b4c62b6
start only csharp and oop hosts
lucyzhang929 Jul 6, 2023
3105853
add logging for disposefunctionhosts
lucyzhang929 Jul 6, 2023
1c6f6dd
start only csharp host
lucyzhang929 Jul 7, 2023
c674ee2
revert commented out code
lucyzhang929 Jul 7, 2023
a00267b
Merge branch 'release/trigger' into luczhan/trigger/codecov
lucyzhang929 Jul 7, 2023
5ef529d
add comment
lucyzhang929 Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/Integration/IntegrationTestFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
using Xunit;
using static Microsoft.Azure.WebJobs.Extensions.Sql.Telemetry.Telemetry;
using System.Linq;

namespace Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration
{
Expand Down Expand Up @@ -47,7 +48,6 @@ public class IntegrationTestFixture : IDisposable
/// </summary>
private readonly List<string> TestFunctions = new() { "GetProductsColumnTypesSerialization", "AddProductColumnTypes", "AddProductExtraColumns", "AddProductMissingColumns", "AddProductMissingColumnsExceptionFunction", "AddProductsNoPartialUpsert", "AddProductIncorrectCasing", "AddProductDefaultPKAndDifferentColumnOrder" };


/// <summary>
/// Host processes for Azure Function CLI.
/// </summary>
Expand All @@ -66,7 +66,11 @@ public IntegrationTestFixture()
private void StartFunctionHosts()
{
string binPath = TestUtils.GetPathToBin();
foreach (SupportedLanguages lang in Enum.GetValues(typeof(SupportedLanguages)))
// Only start CSharp host for CSharp only tests task to ensure code coverage shows in pipeline.
string languages = Environment.GetEnvironmentVariable("LANGUAGES_TO_TEST");
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here explaining why we're doing this? Will help make sure we don't break it in the future 😄

SupportedLanguages[] supportedLanguages = languages == null ? (SupportedLanguages[])Enum.GetValues(typeof(SupportedLanguages))
: languages.Split(',').Select(l => (SupportedLanguages)Enum.Parse(typeof(SupportedLanguages), l)).ToArray();
foreach (SupportedLanguages lang in supportedLanguages)
{
if (lang == SupportedLanguages.CSharp)
{
Expand Down