Skip to content

Fix the race condition by adding the extension reference to build first. #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaddyDev merged 3 commits into from
May 3, 2023
Merged

Fix the race condition by adding the extension reference to build first. #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0afbd25
fix the correct path separator
MaddyDev May 1, 2023
26bf406
add the extension ref to avoid race condition
MaddyDev May 3, 2023
76bcdb7
format files
MaddyDev May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion samples/samples-outofproc/Microsoft.Azure.WebJobs.Extensions.Sql.SamplesOutOfProc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@
<PackageReference Include="Microsoft.AspNetCore.Http" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="../../Worker.Extensions.Sql/src/Microsoft.Azure.Functions.Worker.Extensions.Sql.csproj" />
<ProjectReference
Include="..\..\Worker.Extensions.Sql\src\Microsoft.Azure.Functions.Worker.Extensions.Sql.csproj" />
<!-- We want to build the extension project first since this project references the package
produced by building that. But we don't want it as an actual runtime depdendency -->
<ProjectReference Include="..\..\src\Microsoft.Azure.WebJobs.Extensions.Sql.csproj"
ReferenceOutputAssembly="false" />
</ItemGroup>
<ItemGroup>
<None Update="host.json">
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.Azure.WebJobs.Extensions.Sql.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@
<ItemGroup>
<_Packages Include=".\bin\$(Configuration)\*.nupkg" />
</ItemGroup>
<Copy SourceFiles="@(_Packages)" DestinationFolder="../local-packages" />
<Copy SourceFiles="@(_Packages)" DestinationFolder="..\local-packages" />
<Message Text="Copied sql .nupkg to local-packages" Importance="high" />
</Target>
<Target Name="RemoveNugetPackageCache" BeforeTargets="Build">
<RemoveDir Directories="$(NugetPackageRoot)/$(PackageId.ToLower())/99.99.99"></RemoveDir>
<Message Text="Deleted nuget cache for $(PackageId.ToLower())/99.99.99" Importance="high" />
<RemoveDir Directories="$(NugetPackageRoot)\$(PackageId.ToLower())\99.99.99"></RemoveDir>
<Message Text="Deleted nuget cache for $(PackageId.ToLower())\99.99.99" Importance="high" />
</Target>
</Project>
9 changes: 7 additions & 2 deletions test-outofproc/test-outofproc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Worker.Extensions.Sql\src\Microsoft.Azure.Functions.Worker.Extensions.Sql.csproj" />
<ProjectReference
Include="..\Worker.Extensions.Sql\src\Microsoft.Azure.Functions.Worker.Extensions.Sql.csproj" />
<!-- We want to build the extension project first since this project references the package
produced by building that. But we don't want it as an actual runtime depdendency -->
<ProjectReference Include="..\src\Microsoft.Azure.WebJobs.Extensions.Sql.csproj"
ReferenceOutputAssembly="false" />
</ItemGroup>
<ItemGroup>
<None Update="host.json">
Expand All @@ -27,6 +32,6 @@
</None>
</ItemGroup>
<ItemGroup>
<Using Include="System.Threading.ExecutionContext" Alias="ExecutionContext"/>
<Using Include="System.Threading.ExecutionContext" Alias="ExecutionContext" />
</ItemGroup>
</Project>