Cleanup trigger logging#808
Merged
Charles-Gagnon merged 6 commits intorelease/triggerfrom Apr 18, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of logging cleanup, same stuff as #802
With this we now have :
13 Debug log messages - Extra information that could be useful for debugging, mostly startup/config info
2 Information messages - Telemetry opt-out and connection re-established messages
6 Warning messages - Non-critical errors
28 Error messages - Critical errors that indicate something is wrong
I plan on doing another pass after this is in to verify that the levels we have stuff at makes sense, but this should be pretty much complete at this point. Normal execution should only have a dozen or so messages per instance on startup with the occasional status update message.