Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various DF bugs #783

Merged
merged 6 commits into from
Apr 18, 2022
Merged

Fix various DF bugs #783

merged 6 commits into from
Apr 18, 2022

Conversation

davidmrdavid
Copy link
Contributor

@davidmrdavid davidmrdavid commented Apr 4, 2022 •
edited
Loading

Issue describing the changes in this PR

This PR contains some of the changes originally proposed in #746

resolves #727, #685

This PR contains a few small DF bug patches. The behavioral changes are listed below.

  1. The context object now exposes the .InstanceId field, as is the case in other PLs
  2. The context object now exposes and correctly updates its IsReplaying flag
  3. The DF SDK now correctly parses the output of WaitForExternalEvent Tasks.
  4. The Start-DurableOrchestration CmdLetnow accepts anInstanceId` parameter, as is the case in other PLs

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This should be backported to all DF-supported branches. Can someone help me list them?

@davidmrdavid
enable isReplaying flag
5603b2f 
patch test

patch test

fix IsReplaying flag
@davidmrdavid
enable instanceId
f9d1749 
add InstanceId to Start-DurableOrchestration
@davidmrdavid
add test
76ea57e
@davidmrdavid
add test for external event
6f2dbe8 
patch e2e test setup

encode as app/json

remove typo in test-script

patch httpContent's content
@davidmrdavid davidmrdavid changed the title [WIP] Add DF patches Fix various DF bugs Apr 7, 2022
@davidmrdavid davidmrdavid marked this pull request as ready for review April 7, 2022 22:57
@davidmrdavid davidmrdavid requested review from Francisco-Gamino, AnatoliB and michaelpeng36 and removed request for Francisco-Gamino and AnatoliB April 7, 2022 22:57
AnatoliB
AnatoliB approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidmrdavid davidmrdavid merged commit 54b90b9 into dev Apr 18, 2022
@davidmrdavid davidmrdavid deleted the dajusto/df-patches branch April 18, 2022 17:56
davidmrdavid added a commit that referenced this pull request Apr 18, 2022
@davidmrdavid
Fix various DF bugs (#783)
31f941b
@davidmrdavid davidmrdavid mentioned this pull request Apr 18, 2022
Merged
davidmrdavid added a commit that referenced this pull request Apr 18, 2022
@davidmrdavid
Fix various DF bugs (#783)
00e23e7
@davidmrdavid davidmrdavid mentioned this pull request Apr 18, 2022
Merged
davidmrdavid added a commit that referenced this pull request May 24, 2022
@davidmrdavid
Port "Fix various DF bugs" to v4.x/ps7.0 (#796)
004591d 
* Fix various DF bugs (#783)

* remove release_notes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnatoliB AnatoliB AnatoliB approved these changes

@Francisco-Gamino Francisco-Gamino Awaiting requested review from Francisco-Gamino

@michaelpeng36 michaelpeng36 Awaiting requested review from michaelpeng36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context.InstanceId cannot be accessed
2 participants
@davidmrdavid @AnatoliB