Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update argument parsing and change a namespace name #12

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Update argument parsing and change a namespace name #12

merged 3 commits into from
Aug 28, 2018

Conversation

daxian-dbw
Copy link
Contributor

Update argument parsing code with the formal way.
Update a namespace name to be consistent.
Add Set-ExecutionPolicy for windows platform when initializing the Runspace.

TylerLeonhardt
TylerLeonhardt approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor nit to update the CommandLineParser version.

src/Azure.Functions.PowerShell.Worker/Azure.Functions.PowerShell.Worker.csproj Outdated
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="CommandLineParser" Version="2.2.1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is 2.3.0 which was released 14 days ago:
https://www.nuget.org/packages/CommandLineParser/

can you update this to that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we will need to register this usage in the open source portal but I can do that once we're about to open source the repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version updated. Thanks

src/Azure.Functions.PowerShell.Worker.Messaging/FunctionMessagingClient.cs
@@ -10,7 +10,7 @@
using Grpc.Core;
using Microsoft.Azure.WebJobs.Script.Grpc.Messages;

namespace Azure.Functions.PowerShell.Worker.Messaging
namespace Microsoft.Azure.Functions.PowerShellWorker.Messaging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this. I'm not totally sold that this is the best namespace name but at least we're consistent.

src/Azure.Functions.PowerShell.Worker/Worker.cs
s_ps.AddCommand("Set-ExecutionPolicy")
.AddParameter("ExecutionPolicy", "Unrestricted")
.AddParameter("Scope", "Process")
.Invoke();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I updated this in my PR. We can deal with the merge conflicts later. Yours is better anyway.

src/Azure.Functions.PowerShell.Worker/Worker.cs

// Initialize Rpc client, logger, and PowerShell
s_client = new FunctionMessagingClient(startupArguments.Host, startupArguments.Port);
s_client = new FunctionMessagingClient(arguments.Host, arguments.Port);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on this usage, I guess we can assume that the action call in WithParsed is synchronous. It's an interesting package. In the javascript world the callback pattern doesn't have that guarantee at all.

@daxian-dbw daxian-dbw merged commit bea420c into Azure:dev Aug 28, 2018
@daxian-dbw daxian-dbw deleted the dev branch August 28, 2018 21:19
davidmrdavid added a commit that referenced this pull request Apr 7, 2022
@davidmrdavid
# This is a combination of 37 commits.
3642ec0 
# This is the 1st commit message:

separate DF SDK classes from DF worker classes

# This is the commit message #2:

fix typo

# This is the commit message #3:

DurableSDK now compiles by itself

# This is the commit message #4:

Allow ExternalSDK to handle orchestration

# This is the commit message #5:

document next steps

# This is the commit message #6:

allow external SDK to set the user-code's input. Still need to refactor this logic for the worker to continue working with old SDK

# This is the commit message #7:

add import module

# This is the commit message #8:

supress traces

# This is the commit message #9:

avoid nullptr

# This is the commit message #10:

pass tests

# This is the commit message #11:

fix E2E tests

# This is the commit message #12:

develop E2E tests

# This is the commit message #13:

Enabled external durable client (#765)

Co-authored-by: Michael Peng <[email protected]>
# This is the commit message #14:

bindings work

# This is the commit message #15:

conditional binding intialization

# This is the commit message #16:

conditional import

# This is the commit message #17:

Added exception handling logic

# This is the commit message #18:

Revert durableController name to durableFunctionsUtils

# This is the commit message #19:

Ensure unit tests are functioning properly

# This is the commit message #20:

Corrected unit test names

# This is the commit message #21:

Turned repeated variables in unit tests into static members

# This is the commit message #22:

Fixed issue with building the worker

# This is the commit message #23:

Fix E2E test

# This is the commit message #24:

Fixed unit test setup

# This is the commit message #25:

Fixed another unit test setup

# This is the commit message #26:

Remove string representation of booleans

# This is the commit message #27:

patch e2e test
# This is the commit message #28:

remove typo in toString
# This is the commit message #29:

Update PowerShell language worker pipelines (#750)

* Install .Net to a global location

* Remove .Net installation tasks

* Update install .Net 6 task

* Update Windows image to use windows-latest
# This is the commit message #30:

Make throughput warning message visible for tooling diagnosis (#757)


# This is the commit message #31:

Update grpc.tools to version 2.43.0

# This is the commit message #32:

Update Google.Protobuf.Tools to version 3.19.4

# This is the commit message #33:

Revert "Update Google.Protobuf.Tools to version 3.19.4"

This reverts commit bcbd022.

# This is the commit message #34:

Revert "Update grpc.tools to version 2.43.0"

This reverts commit ccb323a.

# This is the commit message #35:

Update Google.Protobuf to 3.19.4 and grpc.tools to  2.43.0 (#762)

* Update grpc.tools to version 2.43.0

* Update Google.Protobuf.Tools to version 3.19.4
# This is the commit message #36:

Switch from Grpc.Core to Grpc.Net.Client (#758)

* Upgraded protobuf versions and removed Grpc.Core dependency

* Updated channel and option types used

* Change channel credentials

* Added http prefix to url

* Add valid URL check and explicitly include credentials
# This is the commit message #37:

Update pipeline logic to generate the SBOM for release builds (#767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxian-dbw @TylerLeonhardt