Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all falsy values appropriately #388

Closed
mhoeger opened this issue Mar 30, 2021 · 1 comment
Closed

Handle all falsy values appropriately #388

mhoeger opened this issue Mar 30, 2021 · 1 comment
Labels
breaking bug engineering P1 v4 model 🚀 Related to the new V4 programming model
Milestone
August 2022

Comments

@mhoeger
Copy link
Contributor

mhoeger commented Mar 30, 2021

As @davidmrdavid, there are places where we do not treat falsy values as proper data and instead treat it as false.

Example: #364

These need to be addressed and proper linting rules need to be put in place to prevent this issue in the future
@AnatoliB AnatoliB mentioned this issue Aug 4, 2021
Open
@ejizba ejizba added the P1 label Jan 28, 2022
@ejizba ejizba added this to the Backlog Candidates milestone Jan 28, 2022
@ejizba ejizba mentioned this issue Apr 5, 2022
Closed
@lilyjma lilyjma added the v4 model 🚀 Related to the new V4 programming model label Jul 18, 2022
@ejizba
Copy link
Contributor

ejizba commented Aug 24, 2022

Minor details might still change, but overall this was addressed in Azure/azure-functions-nodejs-library@9e6a842 as a part of the new programming model. I've started a doc here with more information: https://aka.ms/AzFuncNodeV4

@ejizba ejizba closed this as completed Aug 24, 2022
ejizba added a commit to Azure/azure-functions-nodejs-library that referenced this issue Aug 25, 2022
@ejizba
Clean up camel case and typed data parsing
efa5fb3 
Main points:
- We don't want `toCamelCase` to call `fromRpcTypedData` because it traverses an entire object recursively and only the top level objects should be RpcTypedData
- We will remove triggerMetadata from http/timer triggers. That information is best found on the request/timer objects instead

Related to all of these bugs:
Azure/azure-functions-nodejs-worker#607
Azure/azure-functions-nodejs-worker#274
Azure/azure-functions-nodejs-worker#204
Azure/azure-functions-nodejs-worker#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking bug engineering P1 v4 model 🚀 Related to the new V4 programming model
Projects
None yet
Milestone
August 2022
Development

No branches or pull requests
3 participants
@mhoeger @ejizba @lilyjma