Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify capabilities in setup #255

Merged
merged 3 commits into from
May 15, 2024
Merged

Add ability to specify capabilities in setup #255

merged 3 commits into from
May 15, 2024

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented May 8, 2024

and clarify that setup options are merged instead of replaced. Otherwise there would be no way for multiple places (i.e. the user's app and an otel package) to adjust setup config.

Related to otel work #245, we will need to do something like this:

app.setup({
    capabilities: {
        WorkerOpenTelemetryEnabled: true,
    },
});

And clarify that setup options are merged instead of replaced. Otherwise there would be no way for multiple places (i.e. the user's app and an otel package) to adjust setup config.
@ejizba ejizba requested a review from castrodd May 8, 2024 19:12
src/ProgrammingModel.ts Outdated Show resolved Hide resolved
test/setup.test.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants