Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support params when streaming #238

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Support params when streaming #238

merged 2 commits into from
Mar 19, 2024

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Mar 15, 2024

And fix headers to match original user's request. Both of these are made possible because of the trigger metadata property. I tried using query from here as well, but it ended up being the worst of both worlds - it doesn't fix the query array bug (#168) but it also doesn't match the old non-stream behavior. So I left our current logic which fixes the query array bug.

I did a small refactor in the first commit and second commit is the actual change.

Fixes #229

@ejizba ejizba merged commit 7e61ae1 into v4.x Mar 19, 2024
11 checks passed
@ejizba ejizba deleted the ej/streamV2 branch March 19, 2024 18:02
@PCOffline
Copy link

PCOffline commented Mar 27, 2024

Hey, does this mean that the latest 4.x version support arrays in query params out of the box?

@ejizba
Copy link
Contributor Author

ejizba commented Mar 27, 2024

@PCOffline only if you have the preview stream feature enabled. More info here: https://aka.ms/AzFuncNodeHttpStreams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Params are missing when using http streams
3 participants