Limit dotnet-isolated specialization to 64 bit host process by kshyju · Pull Request #9553 · Azure/azure-functions-host

kshyju · 2023-09-20T13:58:54Z

With this change, specialization for dotnet isolated using native placeholder will happen only if the host process is 64 bit.
Our Linux distros are 64 bit and customers cannot change that via portal.

https://learn.microsoft.com/en-us/azure/azure-functions/dotnet-isolated-process-guide#placeholders-preview

Pull request checklist

My changes do not require documentation changes
- Otherwise: Documentation issue linked to PR
My changes should not be added to the release notes for the next release
- Otherwise: I've added my notes to release_notes.md
My changes do not need to be backported to a previous version
- Otherwise: Backport tracked by issue/PR #issue_or_pr
My changes do not require diagnostic events changes
- Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
I have added all required tests (Unit tests, E2E tests)

safihamid · 2023-09-22T16:11:32Z

            if (UsePlaceholderChannel(rpcWorkerChannel))

if 'if statement' returns true, maybe better to add a log here that verifies we are using native placeholder and log the PID and process name like mawsfn.... this is to cross check with what DWAS reports as exact match.

Refers to: src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs:126 in 4b480db. [](commit_id = 4b480db3f4c9c58e5207dc2c65bdcb03bf9fa601, deletion_comment = False)

kshyju · 2023-09-26T15:45:22Z

            if (UsePlaceholderChannel(rpcWorkerChannel))
if 'if statement' returns true, maybe better to add a log here that verifies we are using native placeholder and log the PID and process name like mawsfn.... this is to cross check with what DWAS reports as exact match.

Refers to: src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs:126 in 4b480db. [](commit_id = 4b480db, deletion_comment = False)

We already log the process id inside the method called inside if (UsePlaceholderChannel(rpcWorkerChannel))
https://github.com/Azure/azure-functions-host/blob/v4.27.1/src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs#L554

safihamid · 2023-09-26T15:53:49Z

Can we add process name as well?

In reply to: 1735813698

kshyju · 2023-09-26T16:41:36Z

if 'if statement' returns true, maybe better to add a log here that verifies we are using native placeholder and log the PID and process name like mawsfn.... this is to cross check with what DWAS reports as exact match.

Discussed offline. The process name here is "FunctionsNetHost". the data which starts with "mawsfn" is the runtime sitename which we log in the "RuntimeSiteName" for every log entry.

safihamid

FinVamp1

Approved, thanks for adding the Event Name.

* Skipping native placeholder specialization if host is not 64 bit process * formatting linting fix * Stylecop fix. * fix indentation * Adding E2E test. * Improving log message. * Switch from LogDebug to LogInformation * Fix tests to reflect logging changes * Logging with EventId * Logging using an event name * Updated release notes after rebase merge

* Updating patch version * Sending command line args with functions- prefix to prevent conflicts (#9514) * Sending a second copy of command line args with "FUNCTIONS_" prefix * Cleanup * Sending a second copy of command line args with "FUNCTIONS_" prefix * switched to functions- prefix * Removed duplicate port from functions_uri * Switching to kebab case for the new args * Update test * Update native placeholder package to handle new args * Update release notes. * Limit dotnet-isolated specialization to 64 bit host process (#9553) * Skipping native placeholder specialization if host is not 64 bit process * formatting linting fix * Stylecop fix. * fix indentation * Adding E2E test. * Improving log message. * Switch from LogDebug to LogInformation * Fix tests to reflect logging changes * Logging with EventId * Logging using an event name * Updated release notes after rebase merge * Handling env reload response from native placeholder for failure case. (#9602) * Handling env reload response from native placeholder for failure case. * Almost working except one test needs cleanup * Cleanup * Cleanup * Fixing Worker.Extensions.Http package version to align with Http.AspNetCore package. * Logging error as it is received from the worker. * DotNetIsolatedNativeHost package to 1.0.2 * Inlining a variable (Reverting to previous version) * Updating release notes for 4.27.5 * Update PowerShell Language Workers 7.0 (to version 4.0.2973), 7.2 (to version 4.0.2974), and 7.4 (to version 4.0.2975) (#9528) * Upgrade PowerShell language worker 7.4 to 4.0.2975 * Upgrade PowerShell language worker 7.2 to 4.0.2974 * Upgrade PowerShell language worker 7.0 to 4.0.2973 * Update release notes * Update Java Worker Version to 2.13.0 (#9544) * Update Java Worker Version to 2.13.0 * Update release_notes.md for Java worker --------- Co-authored-by: AzureFunctionsJava <funcdisc@microsoft.com> --------- Co-authored-by: azfuncgh <azfuncgh@github.com> Co-authored-by: Shyju Krishnankutty <connectshyju@gmail.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Shreyas Gopalakrishna <11889130+shreyas-gopalakrishna@users.noreply.github.com> Co-authored-by: AzureFunctionsJava <funcdisc@microsoft.com>

kshyju self-assigned this Sep 20, 2023

kshyju marked this pull request as ready for review September 20, 2023 14:18

kshyju requested a review from a team as a code owner September 20, 2023 14:18

liliankasem approved these changes Sep 22, 2023

View reviewed changes

kshyju requested a review from safihamid September 22, 2023 15:04

safihamid reviewed Sep 22, 2023

View reviewed changes

Comment thread src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs Outdated

safihamid reviewed Sep 22, 2023

View reviewed changes

Comment thread src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs Outdated

safihamid reviewed Sep 22, 2023

View reviewed changes

Comment thread release_notes.md Outdated

kshyju requested review from brettsam and safihamid September 26, 2023 15:45

safihamid reviewed Sep 26, 2023

View reviewed changes

Comment thread src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs Outdated

brettsam reviewed Sep 27, 2023

View reviewed changes

Comment thread src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs Outdated

kshyju added 11 commits September 27, 2023 14:29

Skipping native placeholder specialization if host is not 64 bit process

3b227d1

formatting linting fix

3d31527

Stylecop fix.

8e232f1

fix indentation

046bec3

Adding E2E test.

d175f05

Improving log message.

aed0296

Switch from LogDebug to LogInformation

0069103

Fix tests to reflect logging changes

fbbea73

Logging with EventId

b34c5b9

Logging using an event name

c52f68f

Updated release notes after rebase merge

7bb3a5b

kshyju force-pushed the shkr/short_citcuit_specialization branch from 3caef21 to 7bb3a5b Compare September 27, 2023 21:32

kshyju requested review from FinVamp1 and safihamid September 27, 2023 21:54

kshyju requested a review from brettsam September 27, 2023 21:54

safihamid approved these changes Sep 27, 2023

View reviewed changes

FinVamp1 approved these changes Sep 28, 2023

View reviewed changes

kshyju merged commit 13cf289 into dev Sep 29, 2023

kshyju deleted the shkr/short_citcuit_specialization branch September 29, 2023 15:46

mattchenderson mentioned this pull request Oct 3, 2023

Log a warning when placeholder setting configured but app is 32-bit #9585

Closed

kshyju mentioned this pull request Oct 12, 2023

4.27.5 Hotfix #9607

Closed

8 tasks

VpOfEngineering mentioned this pull request Oct 12, 2023

4.27.5 hotfix #9609

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Limit dotnet-isolated specialization to 64 bit host process#9553

Limit dotnet-isolated specialization to 64 bit host process#9553
kshyju merged 11 commits intodevfrom
shkr/short_citcuit_specialization

kshyju commented Sep 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

safihamid commented Sep 22, 2023 •

edited

Loading

Uh oh!

kshyju commented Sep 26, 2023

Uh oh!

Uh oh!

safihamid commented Sep 26, 2023

Uh oh!

kshyju commented Sep 26, 2023

Uh oh!

Uh oh!

safihamid left a comment

Uh oh!

FinVamp1 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kshyju commented Sep 20, 2023

Pull request checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

safihamid commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kshyju commented Sep 26, 2023

Uh oh!

Uh oh!

safihamid commented Sep 26, 2023

Uh oh!

kshyju commented Sep 26, 2023

Uh oh!

Uh oh!

safihamid left a comment

Choose a reason for hiding this comment

Uh oh!

FinVamp1 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

safihamid commented Sep 22, 2023 •

edited

Loading