-
Notifications
You must be signed in to change notification settings - Fork 482
Scaler apis #9131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scaler apis #9131
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cce9baf
Scaler apis - function host part
alrod 3bd4b4c
Fix ExternalStartup_Succeeds
alrod 6ec6eec
Fixing comments
alrod 7f8bc8e
Fix ScaleOptionsSetup_Works_As_Expected
alrod 2bf143e
remove FunctionsScaleManager
alrod f8c51db
Last fixes
alrod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -317,8 +317,8 @@ public async Task<IActionResult> GetScaleStatus([FromBody] ScaleStatusContext co | |
| } | ||
|
|
||
| // TEMP: Once https://github.com/Azure/azure-functions-host/issues/5161 is fixed, we should take | ||
| // FunctionsScaleManager as a parameter. | ||
| if (Utility.TryGetHostService(scriptHostManager, out FunctionsScaleManager scaleManager)) | ||
| // IScaleStatusProvider as a parameter. | ||
| if (Utility.TryGetHostService(scriptHostManager, out IScaleStatusProvider scaleManager)) | ||
| { | ||
| var scaleStatus = await scaleManager.GetScaleStatusAsync(context); | ||
| return new ObjectResult(scaleStatus); | ||
|
|
@@ -327,7 +327,7 @@ public async Task<IActionResult> GetScaleStatus([FromBody] ScaleStatusContext co | |
| { | ||
| // This case should never happen. Because this action is marked RequiresRunningHost, | ||
| // it's only invoked when the host is running, and if it's running, we'll have access | ||
| // to the FunctionsScaleManager. | ||
| // to the IScriptHostManager. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be IScaleStatusProvider |
||
| return StatusCode(StatusCodes.Status503ServiceUnavailable); | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using Microsoft.Azure.WebJobs.Host.Scale; | ||
| using Microsoft.Extensions.Configuration; | ||
| using Microsoft.Extensions.Options; | ||
|
|
||
| namespace Microsoft.Azure.WebJobs.Script.Configuration | ||
| { | ||
| internal class ScaleOptionsSetup : IConfigureOptions<ScaleOptions> | ||
| { | ||
| private readonly IEnvironment _environment; | ||
|
|
||
| public ScaleOptionsSetup(IEnvironment environment) | ||
| { | ||
| _environment = environment; | ||
| } | ||
|
|
||
| public void Configure(ScaleOptions options) | ||
| { | ||
| options.IsRuntimeScalingEnabled = _environment.IsRuntimeScaleMonitoringEnabled(); | ||
| options.IsTargetScalingEnabled = _environment.IsTargetBasedScalingEnabled(); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming/comments no longer match type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: one more in Line 330: FunctionsScaleManager does not exist anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the name of the parameter to match as well - "scaleStatusProvider"