Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading NodeJsWorker to 4.0.0 #7704

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Upgrading NodeJsWorker to 4.0.0 #7704

merged 4 commits into from
Sep 28, 2021

Conversation

alrod
Copy link
Member

@alrod alrod commented Sep 28, 2021

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@alrod alrod merged commit 82eb16d into v4.x Sep 28, 2021
@alrod alrod deleted the alrod-upgrade-nodejs branch September 28, 2021 17:36
Francisco-Gamino
Francisco-Gamino approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Sep 30, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

@brettsam brettsam brettsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrod @brettsam @Francisco-Gamino