Skip file watching in ReadOnly mode #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebbo
reviewed
Feb 23, 2018
| @@ -92,6 +84,15 @@ public ScriptHostManager(ScriptHostConfiguration config, IScriptEventManager eve | |||
| _structuredLogWriter = new StructuredLogWriter(EventManager, config.RootLogPath); | |||
| _performanceManager = hostPerformanceManager ?? new HostPerformanceManager(settingsManager, _config.HostHealthMonitor); | |||
|
|
|||
| if (config.FileWatchingEnabled && !settingsManager.FileSystemIsReadOnly) | |||
There was a problem hiding this comment.
Isn't the check for !settingsManager.FileSystemIsReadOnly redundant here, since you set FileWatchingEnabled to false if it's read-only?
There was a problem hiding this comment.
Unfortunately no - this ctor is called before any hosts are created/initialized. This is the manager of hosts so creates them later. A little confusing as is I agree. At this point FileWatchingEnabled will always have the default value of true and that only changes later when we read host.json config. We might be able to improve this later.
davidebbo
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another change related to #2230. If we're in ReadOnly mode, we don't need to be monitoring script files for changes. The other set of changes were in #2428.