Adding empty remote message check in the SystemLogger#11473
Merged
Conversation
RohitRanjanMS
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the exception sanitization logic to handle empty or whitespace strings in RPC exceptions. The changes prevent unnecessary string operations on null or whitespace strings when redacting remote messages from RPC exceptions.
- Modified the condition to check for non-whitespace remote messages instead of just non-null values
- Added null/whitespace checks before performing string replacement operations to avoid errors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/WebJobs.Script.WebHost/Extensions/ExceptionExtensions.cs | Enhanced null/whitespace handling in GetSanitizedExceptionDetails by adding guards before string.Replace operations |
| test/WebJobs.Script.Tests/Extensions/ExceptionExtensionsTests.cs | Added test coverage for RPC exception sanitization with both populated and empty string scenarios |
fabiocav
reviewed
Nov 5, 2025
fabiocav
approved these changes
Nov 5, 2025
mathewc
approved these changes
Nov 5, 2025
fabiocav
approved these changes
Nov 5, 2025
mathewc
approved these changes
Nov 5, 2025
RohitRanjanMS
added a commit
that referenced
this pull request
Nov 5, 2025
* Adding empty string check.
RohitRanjanMS
added a commit
that referenced
this pull request
Nov 5, 2025
* Adding empty string check.
RohitRanjanMS
added a commit
that referenced
this pull request
Nov 5, 2025
* Update version to 4.1044.500 * Clear release notes * Adding empty remote message check in the SystemLogger (#11473) * Adding empty string check. * Update release notes formatting and content --------- Co-authored-by: azure-functions-release[bot] <223311270+azure-functions-release[bot]@users.noreply.github.com>
RohitRanjanMS
added a commit
that referenced
this pull request
Nov 6, 2025
* Adding empty string check.
RohitRanjanMS
added a commit
that referenced
this pull request
Nov 6, 2025
* Update version to 4.1044.350 * Clear release notes * Adding empty remote message check in the SystemLogger (#11473) * Adding empty string check. * Revise release notes structure and content Updated release notes format and added new entries. --------- Co-authored-by: azure-functions-release[bot] <223311270+azure-functions-release[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string.Replace is throwing exception if the remote message is empty.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information