docs: update call_http docstring to mention dict support (Fixes #518) #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-s31
requested review from
andystaples,
bachuv,
cgillum and
nytian
as code owners
Contributor
|
Thanks for the PR @siddharth-s31 Can you fix the error from CI? it's just line 251 was too long |
siddharth-s31
force-pushed
the
docs-update-call-http
branch
from
ae1f4b5 to
8bca7b5
Compare
Author
|
I have updated the line @nytian The CI check should pass now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #518
Per the discussion in the issue, I have updated the docstring for
call_httpto explicitly state thatcontentaccepts JSON-serializable dictionaries.As requested by @davidmrdavid, I have limited this change to the documentation only and left the type hints unchanged.