Skip to content

Conversation

@carlvitzthum
Copy link
Contributor

See: #224

Changes

  • JSON serialize CallActivityWithRetryAction.input_ (based on CallActivityAction.input_`)
  • Added test_retries_with_serializable_input in test_retries.py
    • New tests fails without CallActivityWithRetryAction change, as expected

@ghost
Copy link

ghost commented Nov 18, 2020

CLA assistant check
All CLA requirements met.

@davidmrdavid davidmrdavid self-requested a review November 18, 2020 21:06
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution ⚡

@davidmrdavid davidmrdavid merged commit af482d2 into Azure:dev Nov 18, 2020
@carlvitzthum carlvitzthum deleted the activity_retries branch November 19, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants