Conversation
bachuv
left a comment
There was a problem hiding this comment.
Looks good to me! I would like to address the comments from Chris before approving though.
cgillum
left a comment
There was a problem hiding this comment.
High-level question: this seems like a pretty obvious thing to do, and I don't recall why we didn't consider it originally. Do you see any downsides with using IDurableClient instead of IOrchestrationService?
No, I don't see any. I cannot say exactly why it wasn't done this way to start (I didn't write it). I am guessing maybe it was because the |
This PR changes
LocalGrpcListenerto useIDurableClientin select places as part of its implementation. Previously we usedIOrchestrationServicedirectly to implement the gRPC calls. However, this means logic that is part ofTaskHubClientis not ran. This is not a problem today, but it will be an issue for our distributed tracing improvements. Our tracing work has logic inTaskHubClientthat is essential for it to all work.This PR also introduces more orchestrations to the smoke test project for easier manual testing of multiple orchestration patterns.
Issue describing the changes in this PR
resolves an issue for distributed tracing work
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.cs