-
Notifications
You must be signed in to change notification settings - Fork 201
Worker instrumentation #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RohitRanjanMS
wants to merge
7
commits into
main
Choose a base branch
from
roranjan/worker-instrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+483
−336
Open
Worker instrumentation #3195
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4fee6df
Updating worker instrumentation.
RohitRanjanMS e6922ed
Remove empty lines.
RohitRanjanMS e8f5a11
Adding a test for empty version.
RohitRanjanMS 422b21e
Addressing review comments.
RohitRanjanMS f5002ad
Updating default OpenTelemetrySchemaVersion to 1.37
RohitRanjanMS 0f40ec6
Setting default schemaversion to 1.17
RohitRanjanMS 950b26f
Addressing review comments.
RohitRanjanMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,23 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using System.Collections.Generic; | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker | ||
| { | ||
| internal sealed class DefaultTraceContext : TraceContext | ||
| { | ||
| public DefaultTraceContext(string traceParent, string traceState) | ||
| public DefaultTraceContext(string traceParent, string traceState, IReadOnlyDictionary<string, string> attributes) | ||
| { | ||
| TraceParent = traceParent; | ||
| TraceState = traceState; | ||
| Attributes = attributes; | ||
| } | ||
|
|
||
| public override string TraceParent { get; } | ||
|
|
||
| public override string TraceState { get; } | ||
|
|
||
| public override IReadOnlyDictionary<string, string> Attributes { get; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 0 additions & 110 deletions
110
src/DotNetWorker.Core/Diagnostics/ActivityExtensions.cs
This file was deleted.
Oops, something went wrong.
66 changes: 0 additions & 66 deletions
66
src/DotNetWorker.Core/Diagnostics/FunctionActivitySourceFactory.cs
This file was deleted.
Oops, something went wrong.
61 changes: 0 additions & 61 deletions
61
src/DotNetWorker.Core/Diagnostics/FunctionInvocationScope.cs
This file was deleted.
Oops, something went wrong.
5 changes: 3 additions & 2 deletions
5
src/DotNetWorker.Core/Diagnostics/OpenTelemetrySchemaVersion.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Diagnostics | ||
| { | ||
| internal enum OpenTelemetrySchemaVersion | ||
| { | ||
| v1_17_0 | ||
| V1_17_0, | ||
| V1_37_0 | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/DotNetWorker.Core/Diagnostics/Telemetry/IFunctionTelemetryProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Diagnostics; | ||
|
|
||
| /// <summary> | ||
| /// Provides methods for telemetry data collection related to function invocations. | ||
| /// </summary> | ||
| /// <remarks>This interface defines methods to retrieve telemetry attributes and manage the activity lifecycle for | ||
| /// function invocations, enabling detailed monitoring and diagnostics.</remarks> | ||
| internal interface IFunctionTelemetryProvider | ||
| { | ||
| /// <summary> | ||
| /// Returns the attributes to be applied to the Activity/Scope for this invocation. | ||
| /// </summary> | ||
| IEnumerable<KeyValuePair<string, object>> GetTelemetryAttributes(FunctionContext ctx); | ||
|
|
||
| /// <summary> | ||
| /// Starts the Activity for this invocation. | ||
| /// </summary> | ||
| Activity? StartActivityForInvocation(FunctionContext ctx); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.