Skip to content

Return null if cosmos db input can't find item#2942

Merged
liliankasem merged 9 commits intoAzure:mainfrom
florianlenz96:florianlenz/fix-cosmos-exception
Jan 30, 2025
Merged

Return null if cosmos db input can't find item#2942
liliankasem merged 9 commits intoAzure:mainfrom
florianlenz96:florianlenz/fix-cosmos-exception

Conversation

@florianlenz96
Copy link
Copy Markdown
Contributor

@florianlenz96 florianlenz96 commented Jan 28, 2025

Issue describing the changes in this PR

resolves #2545

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Hi there,

it's my first PR in an open source repo. If I need to change anything or you have questions, please contact me.

Additional PR information

@florianlenz96
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@fabiocav fabiocav requested review from jviau and liliankasem and removed request for jviau January 29, 2025 21:51
Copy link
Copy Markdown
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@liliankasem do you have any concerns with this being a breaking behavior change?

@liliankasem
Copy link
Copy Markdown
Member

LGTM. Thank you for your contribution!

@liliankasem do you have any concerns with this being a breaking behavior change?

I think it could be for folks depending on the failure in this scenario, but then again it will be a failure in every scenario today so I don't think there would be any major/breaking impact?

Comment thread test/Worker.Extensions.Tests/Cosmos/CosmosDBConverterTests.cs Outdated
Comment thread release_notes.md Outdated
Comment thread test/Worker.Extensions.Tests/Cosmos/CosmosDBConverterTests.cs
@florianlenz96
Copy link
Copy Markdown
Contributor Author

@liliankasem I've resolved your notes. Can you verify. Thanks in advance.

Comment thread extensions/Worker.Extensions.CosmosDB/release_notes.md Outdated
Comment thread extensions/Worker.Extensions.CosmosDB/release_notes.md Outdated
@florianlenz96 florianlenz96 changed the title Return null if cosmos db input can't found item Return null if cosmos db input can't find item Jan 30, 2025
@liliankasem
Copy link
Copy Markdown
Member

/azp run dotnet-worker.public

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jviau
Copy link
Copy Markdown
Contributor

jviau commented Jan 30, 2025

/azp run extensions.cosmos.public

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liliankasem liliankasem merged commit 9314bae into Azure:main Jan 30, 2025
@liliankasem
Copy link
Copy Markdown
Member

@florianlenz96 thanks for contributing! Release is out: https://www.nuget.org/packages/Microsoft.Azure.Functions.Worker.Extensions.CosmosDB/4.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CosmosDBInput returning 500 instead of 404 when item does not exist

3 participants