Skip to content

Assert inner-build TFM is what we expect#2222

Merged
jviau merged 4 commits intomainfrom
jviau/validate-inner-tfm
Jan 23, 2024
Merged

Assert inner-build TFM is what we expect#2222
jviau merged 4 commits intomainfrom
jviau/validate-inner-tfm

Conversation

@jviau
Copy link
Copy Markdown
Contributor

@jviau jviau commented Jan 18, 2024

Issue describing the changes in this PR

resolves #1995

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR introduces an explicit failure if the inner-build TFM is overridden. Suppressing global properties was already performed as part of #1946, but this is an extra mile to avoid any future vague issues.

Comment thread sdk/Sdk/ExtensionsCsprojGenerator.cs
Comment thread sdk/Sdk/ExtensionsCsprojGenerator.cs
Comment thread sdk/release_notes.md
@jviau jviau merged commit 111f240 into main Jan 23, 2024
@jviau jviau deleted the jviau/validate-inner-tfm branch January 23, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure function startup failure "Could not load file or assembly" after upgrading to latest version

2 participants