Skip to content

Adding functions uri in environment variables in FunctionsNetHost#2171

Merged
surgupta-msft merged 2 commits intomainfrom
surgupta/cmdline-args-fix2
Dec 27, 2023
Merged

Adding functions uri in environment variables in FunctionsNetHost#2171
surgupta-msft merged 2 commits intomainfrom
surgupta/cmdline-args-fix2

Conversation

@surgupta-msft
Copy link
Copy Markdown
Contributor

Issue describing the changes in this PR

resolves #2121

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft surgupta-msft marked this pull request as ready for review December 27, 2023 20:05
@surgupta-msft surgupta-msft requested a review from kshyju December 27, 2023 20:05
Comment thread host/src/FunctionsNetHost/Grpc/IncomingGrpcMessageHandler.cs Outdated
@kshyju
Copy link
Copy Markdown
Member

kshyju commented Dec 27, 2023

We should also bump the version here
Once merged and package is published, we should update host to consume this version. Example PR - Azure/azure-functions-host#9740

@surgupta-msft surgupta-msft merged commit 16a995d into main Dec 27, 2023
@surgupta-msft surgupta-msft deleted the surgupta/cmdline-args-fix2 branch December 27, 2023 22:50
@Wangor
Copy link
Copy Markdown

Wangor commented Dec 28, 2023

Seems promising, is it in the next version or just to update the current host package? Thanks a lot!

@kshyju
Copy link
Copy Markdown
Member

kshyju commented Dec 28, 2023

Seems promising, is it in the next version or just to update the current host package? Thanks a lot!

This will be in the next host version.

@Wangor
Copy link
Copy Markdown

Wangor commented Jan 3, 2024

sorry for the question. I installed the Azure function tools for local debugging. This seems to have still the old workers and hosts. Any timeline when it is updated or can i download the zip and replace some stuff? Thanks a lot for your work!

@kshyju
Copy link
Copy Markdown
Member

kshyju commented Jan 3, 2024

Once the host/core tools version with this fix is released, Visual studio will automatically pull in that version for you. Hopefully this will be out in the second half of January.

@Wangor
Copy link
Copy Markdown

Wangor commented Jan 3, 2024

Thanks. That means Isolated Functions are officially not working on .NET / Azure as long it is not released?
(No clue if it works on azure but makes no sense to deploy untested code? :) )

@kshyju
Copy link
Copy Markdown
Member

kshyju commented Jan 3, 2024

Thanks. That means Isolated Functions are officially not working on .NET / Azure as long it is not released? (No clue if it works on azure but makes no sense to deploy untested code? :) )

Isolated functions will work with the existing features. Any new features we ship will be working only after it is officially released.

If you are experiencing issues when using dotnet isolated functions. please open a new GH issue with relevant details. We are happy to help.

@Wangor
Copy link
Copy Markdown

Wangor commented Jan 3, 2024

Now you make me curious... What i did: Startes Visual Studio, created a isolated function project with a simple httptrigger or scheduled trigger and both did not work at all. In debugging there was the issue that the function host returned a corrupt url. like http://:1234 which seemed to match somehow your fix...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The gRPC channel URI 'http://:' could not be parsed.

3 participants