Conversation
satvu
approved these changes
Dec 15, 2023
jviau
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populating parameter value for nullable types when input binding data is missing the value for the parameter.
Currently when the parameter is nullable type & default value not defined, we are throwing an exception
azure-functions-dotnet-worker/src/DotNetWorker.Core/Context/Features/DefaultFunctionInputBindingFeature.cs
Lines 71 to 81 in 5045bf5
which was different than previous behavior where null value was assigned.
In this PR, If the parameter is nullable or reference types and no value was present in input binding data, we will set the value as
null.Behavior with changes from this PR, when input binding data is missing the value for the parameter/binding.
Pull request checklist
release_notes.mdAdditional information
Additional PR information