Generate correct ScriptFile value when generating metadata.#2103
Merged
Generate correct ScriptFile value when generating metadata.#2103
Conversation
satvu
approved these changes
Nov 28, 2023
Member
satvu
left a comment
satvu
left a comment
There was a problem hiding this comment.
LGTM - just need pipeline tests fixed.
liliankasem
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing function metadata provider to correctly generate ScriptFile property value. Currently it always generate a value which ends with ".dll" and this causes NETFX function apps to fail during function load. This PR adds changes to determine whether the value should be ".dll" or ".exe" and use the appropriate value.
We only need to do this for the entry assembly. Dependent assemblies will be always .dll.
Pull request checklist
release_notes.md