Replace - with _ when generating namespace for generated types#2097
Merged
Replace - with _ when generating namespace for generated types#2097
Conversation
…s not have an overridden (fixed) root namespace value.
9253dd1 to
f67f37f
Compare
satvu
approved these changes
Nov 27, 2023
liliankasem
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today. when you create a new project_(any project type_) in Visual studio with - in the name(Ex: "FOO-BAR"), The tooling will add an explicit root namespace entry to the
.cpsojfile.But we have customers reporting their existing projects with "-" in it running into invalid namespace name issue for the generated types when they upgraded to recent versions of worker sdk.
The fix is to always use the
FunctionsGeneratedCodeNamespacemsbuild proerty value. If user has not provided it, we will set theRootNamespacemsbuild property value as the value ofFunctionsGeneratedCodeNamespace.Pull request checklist
release_notes.md