Skip to content

Ensure generated types are properly documented#2035

Merged
fabiocav merged 3 commits intomainfrom
fabiocav/genxmldoc
Nov 8, 2023
Merged

Ensure generated types are properly documented#2035
fabiocav merged 3 commits intomainfrom
fabiocav/genxmldoc

Conversation

@fabiocav
Copy link
Copy Markdown
Member

@fabiocav fabiocav commented Nov 8, 2023

Issue describing the changes in this PR

resolves #2027

The changes ensure public types and members are documented. It also adds EditorBrowsableAttribute where appropriate to avoid having confusion with those APIs

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@fabiocav fabiocav changed the title Fabiocav/genxmldoc Ensure generated types are properly documented Nov 8, 2023
Comment thread sdk/Sdk.Generators/FunctionExecutor/FunctionExecutorGenerator.Emitter.cs Outdated
Copy link
Copy Markdown
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need here ?

@fabiocav
Copy link
Copy Markdown
Member Author

fabiocav commented Nov 8, 2023

Do we need here ?

Not needed, but doing the same and updating for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated code in release 1.16.0 breaks CS1591

2 participants