Setting text encoding to fix the newline char issue when using StreamReader#2023
Merged
surgupta-msft merged 10 commits intomainfrom Nov 3, 2023
Merged
Setting text encoding to fix the newline char issue when using StreamReader#2023surgupta-msft merged 10 commits intomainfrom
surgupta-msft merged 10 commits intomainfrom
Conversation
jviau
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1935
We noticed that the test -
BlobTrigger_Stream_Succeeds()shows flaky behavior with one of the following outputs -actualandexpectedoutput when the new line is missing -Expected: Hello WorldActual: Hello World[2023-09-13T20:36:29.524Z] Executed 'Func···Condition not reached within timeoutRegarding behavior (3), not seeing this happening recently with many runs I tried via pipeline and not able to repro locally as well, as locally the test always passes.
This PR fixes behavior (2) above, as StreamReader has issues reading newline character and setting the text encoding helps resolving the issue. Ran this PR changes a number of times and did not notice any flaky behavior - runs.
Pull request checklist
release_notes.mdAdditional information
Additional PR information