Skip to content

Setting text encoding to fix the newline char issue when using StreamReader#2023

Merged
surgupta-msft merged 10 commits intomainfrom
surgupta/testfix-102623
Nov 3, 2023
Merged

Setting text encoding to fix the newline char issue when using StreamReader#2023
surgupta-msft merged 10 commits intomainfrom
surgupta/testfix-102623

Conversation

@surgupta-msft
Copy link
Copy Markdown
Contributor

Issue describing the changes in this PR

resolves #1935

We noticed that the test - BlobTrigger_Stream_Succeeds() shows flaky behavior with one of the following outputs -

  1. Test works successfully.
  2. Different actual and expected output when the new line is missing -
    • Expected: Hello World
    • Actual: Hello World[2023-09-13T20:36:29.524Z] Executed 'Func···
    • Test run: link
  3. Error: Condition not reached within timeout

Regarding behavior (3), not seeing this happening recently with many runs I tried via pipeline and not able to repro locally as well, as locally the test always passes.

This PR fixes behavior (2) above, as StreamReader has issues reading newline character and setting the text encoding helps resolving the issue. Ran this PR changes a number of times and did not notice any flaky behavior - runs.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft surgupta-msft requested review from kshyju and satvu November 3, 2023 22:07
@surgupta-msft surgupta-msft merged commit f7606fc into main Nov 3, 2023
@surgupta-msft surgupta-msft deleted the surgupta/testfix-102623 branch November 3, 2023 22:32
fabiocav added a commit that referenced this pull request Nov 9, 2023
fabiocav added a commit that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky tests

2 participants