Skip to content

Include .pdb files for FunctionsNetHost#2002

Merged
kshyju merged 5 commits intomainfrom
shkr/frm-fd86b66fb221b618d949c8845f59daeacb2ce381
Nov 1, 2023
Merged

Include .pdb files for FunctionsNetHost#2002
kshyju merged 5 commits intomainfrom
shkr/frm-fd86b66fb221b618d949c8845f59daeacb2ce381

Conversation

@kshyju
Copy link
Copy Markdown
Member

@kshyju kshyju commented Oct 31, 2023

Include .pdb files for FunctionsNetHost, as per request from @safihamid

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested review from brettsam and fabiocav October 31, 2023 15:24
@jviau
Copy link
Copy Markdown
Contributor

jviau commented Oct 31, 2023

This is only for the build artifact correct? Or is the pdb included in the deployed host somehow?

@kshyju
Copy link
Copy Markdown
Member Author

kshyju commented Oct 31, 2023

This is only for the build artifact correct? Or is the pdb included in the deployed host somehow?

@safihamid suggested to include this in the symbols package we produce as an artifact for host build. So a follow up PR in host pulling in this version of package and updating the symbol zip creation will follow once this change is in,

@jviau
Copy link
Copy Markdown
Contributor

jviau commented Nov 1, 2023

This is only for the build artifact correct? Or is the pdb included in the deployed host somehow?

@safihamid suggested to include this in the symbols package we produce as an artifact for host build. So a follow up PR in host pulling in this version of package and updating the symbol zip creation will follow once this change is in,

We currently embed symbols in the host dlls. @safihamid will this affect our ability to deliver these symbols alongside those embedded ones to customers? I do see those symbols steps in our build, but honestly I am unsure what their purpose is if we are embedding in the dll.

@kshyju kshyju merged commit 8144ded into main Nov 1, 2023
@kshyju kshyju deleted the shkr/frm-fd86b66fb221b618d949c8845f59daeacb2ce381 branch November 1, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants