Skip to content

Make NativeHostIntegration p/invokes blittable#1989

Merged
kshyju merged 4 commits intoAzure:mainfrom
elinor-fung:blittablePInvokes
Nov 8, 2023
Merged

Make NativeHostIntegration p/invokes blittable#1989
kshyju merged 4 commits intoAzure:mainfrom
elinor-fung:blittablePInvokes

Conversation

@elinor-fung
Copy link
Copy Markdown
Contributor

@elinor-fung elinor-fung commented Oct 25, 2023

  • Switch to blittable p/invokes for native host integration - avoids IL stub generation at run time
  • Remove allocation of GCHandle for NativeHostApplication
    • Stick with the singleton method currently being used

@kshyju PTAL

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju self-assigned this Oct 26, 2023
@kshyju
Copy link
Copy Markdown
Member

kshyju commented Oct 30, 2023

Don't merge yet.

Comment thread host/src/FunctionsNetHost/Native/NativeExports.cs
@kshyju kshyju merged commit b528b47 into Azure:main Nov 8, 2023
@elinor-fung elinor-fung deleted the blittablePInvokes branch November 8, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants